admin管理员组文章数量:1344544
I'm rewording this question as I think the original wasn't too clear.
Basically, I have a 'wrapper' directive where I am attempting to dynamically add attributes to one of the wrapped (transcluded) elements. I can get this to work, but Angular doesn't seem to be aware of the new attributes once added.
If I use $pile then Angular does recognise them - but at the expense of double-piling the transcluded content, and in this case it then doubles the number of options in the select tag.
Here is a plunker that shows (with ments) what I am attempting, and the same code follows below for those who can look at code and suggest an answer just by looking:
(note - my ultimate aim is to check the custom directive valid-form-group for the required attribute, and if found to apply it to the contained select tag)
HTML
<body ng-controller="MainCtrl">
<form name="validationForm" novalidate>
<valid-form-group class="form-group" ng-class="{'has-error': validationForm.validInfo.$error.required}" required>
<select ng-model="data.option" ng-options="option.id as option.message for option in selectOptions" name="validInfo" id="validInfo">
<option value="">-- Select a Question --</option>
</select>
</valid-form-group>
</form>
</body>
JS
var app = angular.module('plunker', [])
.controller('MainCtrl', function($scope) {
$scope.selectOptions = [
{id: 1, message: 'First option'},
{id: 2, message: 'Second option'},
{id: 3, message: 'Third option'}
];
})
.directive('validFormGroup', function($pile) {
return {
restrict: 'E',
template: '<div><span ng-transclude></span></div>',
replace: true,
transclude: true,
require: '^form',
link: function(scope, element, attrs, ctrl) {
if (attrs.required !== undefined) {
var selectElement = angular.element(element.find('select'));
// either of the below produce the same results
selectElement.attr('ng-required', true);
//selectElement.attr('required', true);
// if the below is mented out it wont validate
// BUT if it is left in it will repile and add another 3 options
$pile(selectElement)(scope);
}
}
};
});
CSS
.has-error{
border: solid 1px red;
}
Please note that the sample here is using 'required' (or ng-required) as the added attribute to highlight the fact that Angular does not recognise it unless piled.
Any help or ments are wele - a bit disappointed that I can't get this to work, so perhaps there's something fundamental I'm missing...
The plunker should help with visualising my problem.
edit - apologies for the delay in responding to the answers and ments. As mentioned in a ment or two below, personal issues have prevented me from being able to find the time to investigate.
I'm rewording this question as I think the original wasn't too clear.
Basically, I have a 'wrapper' directive where I am attempting to dynamically add attributes to one of the wrapped (transcluded) elements. I can get this to work, but Angular doesn't seem to be aware of the new attributes once added.
If I use $pile then Angular does recognise them - but at the expense of double-piling the transcluded content, and in this case it then doubles the number of options in the select tag.
Here is a plunker that shows (with ments) what I am attempting, and the same code follows below for those who can look at code and suggest an answer just by looking:
(note - my ultimate aim is to check the custom directive valid-form-group for the required attribute, and if found to apply it to the contained select tag)
HTML
<body ng-controller="MainCtrl">
<form name="validationForm" novalidate>
<valid-form-group class="form-group" ng-class="{'has-error': validationForm.validInfo.$error.required}" required>
<select ng-model="data.option" ng-options="option.id as option.message for option in selectOptions" name="validInfo" id="validInfo">
<option value="">-- Select a Question --</option>
</select>
</valid-form-group>
</form>
</body>
JS
var app = angular.module('plunker', [])
.controller('MainCtrl', function($scope) {
$scope.selectOptions = [
{id: 1, message: 'First option'},
{id: 2, message: 'Second option'},
{id: 3, message: 'Third option'}
];
})
.directive('validFormGroup', function($pile) {
return {
restrict: 'E',
template: '<div><span ng-transclude></span></div>',
replace: true,
transclude: true,
require: '^form',
link: function(scope, element, attrs, ctrl) {
if (attrs.required !== undefined) {
var selectElement = angular.element(element.find('select'));
// either of the below produce the same results
selectElement.attr('ng-required', true);
//selectElement.attr('required', true);
// if the below is mented out it wont validate
// BUT if it is left in it will repile and add another 3 options
$pile(selectElement)(scope);
}
}
};
});
CSS
.has-error{
border: solid 1px red;
}
Please note that the sample here is using 'required' (or ng-required) as the added attribute to highlight the fact that Angular does not recognise it unless piled.
Any help or ments are wele - a bit disappointed that I can't get this to work, so perhaps there's something fundamental I'm missing...
The plunker should help with visualising my problem.
edit - apologies for the delay in responding to the answers and ments. As mentioned in a ment or two below, personal issues have prevented me from being able to find the time to investigate.
Share Improve this question edited Jun 30, 2014 at 9:32 Sean asked Jun 19, 2014 at 21:26 SeanSean 3852 gold badges5 silver badges17 bronze badges 4-
Can't you put a conditional
ng-requiredon the item: `ng-required="requiredItem". Like suggested here – Ben Felda Commented Jun 19, 2014 at 21:37 - @Ben - I have a ment in the code sample above: // either of the below produce the same results selectElement.attr('ng-required', true); //selectElement.attr('required', true); Unfortunately (while this still adds the attribute dynamically) it's still not rendered by Angular. Note - I'm using 'required' as a sample here. This could refer to any directive which may have content that needs to be 'recognised' by Angular... – Sean Commented Jun 20, 2014 at 6:33
- Why you are trying to wrap this inside directive? It could be done in a simple way like this plnkr.co/edit/oFyDTa2anUQCLWOkwrW5?p=preview – Ammar Khan Commented Jun 22, 2014 at 19:05
- I am writing a wrapper for form group contents which involves a lot more than just the above (i.e. dynamically adding spans with relevant error messages based on label info etc). However, I'm stuck with the above concept - and I'm not particularly tied to 'include' or 'ng-include' - this is for illustration purposes of my issue only. Thanks for looking though - would appreciate it if you re-looked at the issue with this in mind. It's driving me insane! :) – Sean Commented Jun 22, 2014 at 20:00
5 Answers
Reset to default 3 +50Try this simple directive:
.directive('validFormGroup', function($pile) {
return {
restrict: 'A',
replace: false,
require: '^form',
pile: function (element, attr) {
if (attr.required !== undefined) {
var selectElement = element.find('select');
// either of the below produce the same results
selectElement.attr('ng-required', true);
//selectElement.attr('required', true);
}
}
};
});
And use it as html attribute:
<div valid-form-group class="form-group" ng-class="{'has-error': validationForm.validInfo.$error.required}" required>
<select ng-model="data.option"
ng-options="option.id as option.message for option in selectOptions"
name="validInfo" id="validInfo" >
<option value="">-- Select a Question --</option>
</select>
<br/>
<br/>Required invalid? {{validationForm.validInfo.$error.required||false}}
<br/>
<br/>
</div>
DEMO
Explanation:
I don't use
transcludeat all in this solution as the purpose of this directive is just to modify the html before piling with the scope, there is no need for transcluded content which is overly plicated.Here I handle the
pilefunction instead of thelinkfunction.pilefunction is a great place for you to modify html before linking to the scope.
I can only guess what you are seeing is the result of a double pile during the directives initialization process, that's why you are seeing the double sets of options.
You can solve this by wrapping your pile inside $timeout, which will ensure the pilation happens outside the directive initialization. Here's a working demo and below the directive code:
.directive('validFormGroup', function($pile, $timeout) {
return {
restrict: 'E',
template: '<div><span ng-transclude></span></div>',
replace: true,
transclude: true,
require: '^form',
link: function(scope, element, attrs, ctrl) {
if (attrs.required !== undefined) {
var selectElement = angular.element(element.find('select'));
$timeout(function(){
selectElement.attr('ng-required', true);
$pile(selectElement)(scope);
});
}
}
};
});
PS You can achieve similar bootstrap wrapper functionality by using isolated scope on your directive and then checking if your transcluded input/select element has the required attribute set. Define a function on the isolated scope to check for error and tie this function to the form-group ng-class has-error. This way you dont have to use $timeout at all.
I would like to suggest here a different approach, which i adapted for having dynamic validation. adding validations dynamically to the field, reduces boilerplate html code for each field, i have written a directive for similar purpose. please see the plunker link for example directive... PLUNKER
i have written such directives for all types of fields: number, text, select, textarea, bool, datepicker, etc... the attached plunker gives you an example for text & number field.
the magic of angular happens using below liner:
var newElem = angular.element(template);
element.replaceWith(newElem);
$pile(newElem)(scope);
all other code is just some logical if else part..
You not need to use $pile in this case. I just changed the code to solve your problem. I try to keep as near as possible to your original version to help you understand.
Javascript (added isRequired scope variable based on attrs.required)
.directive('validFormGroup', function($pile) {
return {
restrict: 'E',
template: '<div><span ng-transclude></span></div>',
replace: true,
transclude: true,
require: '^form',
link: function(scope, element, attrs, ctrl) {
if (attrs.required !== undefined) {
//added isRequired
scope.isRequired = true;
var selectElement = angular.element(element.find('select'));
// either of the below produce the same results
//selectElement.attr('ng-required', true);
//selectElement.attr('required', true);
// if the below is mented out it wont validate
// BUT if it is left in it will repile and add another 3 options
//remove $pile
//$pile(selectElement)(scope);
}
}
};
});
HTML (added ng-required=isRequired)
<select ng-model="data.option" ng-options="option.id as option.message for option in selectOptions" name="validInfo" id="validInfo" ng-required="isRequired">
You can refer to plunkr version at http://plnkr.co/edit/BGQo05mTNr1H1HjFXSpf?p=preview
I think this answer your question. If you got more plex scenario, please share.
Updated: (after read through others ment and answer again) If you need dynamic HTML content, you can use this solution - Compiling dynamic HTML strings from database
Another way is to remove ng-*attribute to prevent repile. plunkr version at http://plnkr.co/edit/JpfdvISCZ39heuUfdHt3?p=preview
selectElement.removeAttr('ng-options');
selectElement.removeAttr('ng-model');
I don't have a plete answer however if you you give your directive an isolated scope scope: {}, then on the double pile it can't get the options so fails silently - I tried this in your plunkr and I only got one set of options in the drop down.
I said I don't have a pete answer - I don't believe it is - it seems like a hack and I think there are things on the scope that you do need to share with the directive you might be able to inherit these alone via an inherited scope so that you can maintain the functionality but as I said it feels hacky and doesn't feel right because it doesn't address the fundamental problem of how best to handle the double pile.
本文标签： javascriptCompiling dynamic contentAngularJSStack Overflow
版权声明：本文标题：javascript - Compiling dynamic content - AngularJS - Stack Overflow 内容由网友自发贡献，该文观点仅代表作者本人， 转载请联系作者并注明出处：http://www.betaflare.com/web/1743784727a2538477.html， 本站仅提供信息存储空间服务，不拥有所有权，不承担相关法律责任。如发现本站有涉嫌抄袭侵权/违法违规的内容，一经查实，本站将立刻删除。
发表评论