admin管理员组

文章数量:1410712

This code is not working in Edge browser. The accordion panel does not open and I get this error:

Object doesn't support property or method 'forEach'

const accordionBtn = document.querySelectorAll('.btn-accordion');

accordionBtn.forEach(item => item.addEventListener('click', e => {
    e.preventDefault();

    const currItem = e.currentTarget;

    currItem.classList.toggle("open");
}))

This code is not working in Edge browser. The accordion panel does not open and I get this error:

Object doesn't support property or method 'forEach'

const accordionBtn = document.querySelectorAll('.btn-accordion');

accordionBtn.forEach(item => item.addEventListener('click', e => {
    e.preventDefault();

    const currItem = e.currentTarget;

    currItem.classList.toggle("open");
}))
Share Improve this question edited Aug 14, 2018 at 20:42 TylerH 21.1k79 gold badges79 silver badges114 bronze badges asked Aug 13, 2018 at 14:20 NikolayNikolay 411 silver badge2 bronze badges 8
  • 3 which error are you seeing in the console? Perhaps the element hasn't loaded by the time the script runs - can you do console.log(accordionBtn)? – Paul Fitzgerald Commented Aug 13, 2018 at 14:21
  • The error probably means: "code to new for this browser" – Jonas Wilms Commented Aug 13, 2018 at 14:22
  • 1 I don't think so, arrow functions are supported in Edge, and there isn't anything else too funky in there – Paul Fitzgerald Commented Aug 13, 2018 at 14:24
  • This is console says: "Object doesn't support property or method 'forEach'" – Nikolay Commented Aug 13, 2018 at 14:32
  • [...accordionBtn].forEach(item => item.addEventListener('click', e => { e.preventDefault(); const currItem = e.currentTarget; currItem.classList.toggle("open"); })) This variant works! – Nikolay Commented Aug 13, 2018 at 14:34
 |  Show 3 more ments

2 Answers 2

Reset to default 9

Note this should work in Edge 16+ and across the latest versions of other browsers according to MDN. I manually tested Edge 17 and verified it works there.

Workaround

The issue stems from the fact that querySelectorAll returns a NodeList instead of an Array in all browsers. While Array has supported forEach for some time, only more recently has the API been added to NodeList.

If you want to use this and need to support older browser versions, you can create a trivial polyfill by copying the implementation from Array itself (works in IE9+):

if (window.NodeList && !NodeList.prototype.forEach) {
    NodeList.prototype.forEach = Array.prototype.forEach;
}

What about filter and map?

Also worth noting is that a number of other helpful APIs like filter and map still do not exist on NodeList in any browser. Therefore if you want the full experience, your best bet is to copy the items into a real Array.

In most modern browsers this can be done using Array.from(nodelist) or via the spread syntax [...nodelist]. However, if you need to support IE you can use slice (among other creative techniques) to get the job done:

var arr = Array.prototype.slice.call(nodelist);

This variant works!

const accordionBtn = document.querySelectorAll('.btn-accordion');

[...accordionBtn].forEach(item => item.addEventListener('click', e => {
    e.preventDefault();

    const currItem = e.currentTarget;

    currItem.classList.toggle("open");
}))

本文标签: javascriptWhy is forEach not working in EdgeStack Overflow