javascript - jQuery function prevents addremove class on click - Stack Overflow

admin管理员组

文章数量:1345395

I'm trying to have a div get a new class (which makes it expand) when being clicked, and get it back to the old class (which makes it close) when clicking on a cancel link inside that div.

<div class="new-discussion small">
    <a class="cancel">Cancel</a>
</div>

<script>
    $('.new-discussion.small').click(function() {
        $(this).addClass("expand").removeClass("small");
    });
    $('a.cancel').click(function() {
        $('.new-discussion.expand').addClass("small").removeClass("expand");
    });
</script>

Now, adding the expand class works flawlessly, but closing the panel after clicking on the cancel link only works when I remove this code:

$('.new-discussion.small').click(function() {
    $(this).addClass("expand").removeClass("small");
});

So I guess this must be preventing the second function to work, but I really can't figure out why.

Any ideas? Thanks!

I'm trying to have a div get a new class (which makes it expand) when being clicked, and get it back to the old class (which makes it close) when clicking on a cancel link inside that div.

<div class="new-discussion small">
    <a class="cancel">Cancel</a>
</div>

<script>
    $('.new-discussion.small').click(function() {
        $(this).addClass("expand").removeClass("small");
    });
    $('a.cancel').click(function() {
        $('.new-discussion.expand').addClass("small").removeClass("expand");
    });
</script>

Now, adding the expand class works flawlessly, but closing the panel after clicking on the cancel link only works when I remove this code:

$('.new-discussion.small').click(function() {
    $(this).addClass("expand").removeClass("small");
});

So I guess this must be preventing the second function to work, but I really can't figure out why.

Any ideas? Thanks!

• javascript
• jquery
• html
• css

Share Improve this question Follow edited Apr 19, 2013 at 21:38 Sachin Jain 21.9k3434 gold badges110110 silver badges176176 bronze badges asked Apr 19, 2013 at 21:16 LennartLennart 32711 gold badge55 silver badges1010 bronze badges 5

• 1 You know you can use .toggleClass instead of both adding and removing, right? – VoidKing Commented Apr 19, 2013 at 21:18
• Yep, doesn't work either though. – Lennart Commented Apr 19, 2013 at 21:19
• Speculation: Since 'a.cancel' is within '.new-discussion.small' is it registering the $('.new-discussion.small').click even when you are clicking the a.cancel? – VoidKing Commented Apr 19, 2013 at 21:23
• In my above ment, I am probably wrong, but thought it might be something to check, since you say that it works when you remove $('.new-discussion.small').click(function() { $(this).addClass("expand").removeClass("small"); }); – VoidKing Commented Apr 19, 2013 at 21:24
• Yeah, I thought about that. However, when clicking cancel, the panel is already open, so the 'small' class has already been removed - therefore, that event shouldn't register. Or does it? It would be a logical explanation. – Lennart Commented Apr 19, 2013 at 21:26

Add a ment  | 

3 Answers 3

Sorted by: Reset to default 6

Try this

$('a.cancel').click(function() {
    $('.new-discussion.expand').addClass("small").removeClass("expand");
    return false;
});

Reason may be your click event is getting propagated to parent which is also listening to click event.

Since your a element is inside the .new-discussion element, when you click on the a, it also fires the click event on the parent element because the event is bubbling up.

To fix it, you can stop the propagation of the event by calling e.stopPropagation();. That will prevent any parent handlers to be executed.

$('a.cancel').click(function(e) {
    e.stopPropagation();
    $('.new-discussion.expand').addClass("small").removeClass("expand");
});

Since the link is inside the <div>, it's using both click methods at once. It might help to do a check to see if the container is already open before proceeding:

<script>
    $('.new-discussion.small').click(function() {
        if ($(this).hasClass("small")) {
            $(this).addClass("expand").removeClass("small");
        }
    });
    $('a.cancel').click(function() {
        $(this).parent('.expand').addClass("small").removeClass("expand");
    });
</script>

本文标签： javascriptjQuery function prevents addremove class on clickStack Overflow