javascript - onclick redirect to different url - Stack Overflow

admin管理员组

文章数量:1315334

I am creating a pulldown menu that pushes the user to a selected url. In the list i have several values that are set at 0 which i use for headers in the list. I have set them to 0 so they do nothing.

This works for the first one in the list which has a value of 0 but the others that do have a value of 0 still redirects the browser to a new website with the same domain and /0 at the end? What am i missing?

<select onchange="if (this.selectedIndex > 0) document.location.href=this.value;">
<option value="0" selected="selected">More...</option>
<option value="0">----- Locations  -----</option>
<option value="/">location1</option>
<option value="/">location2</option>
<option value="/">location3</option>
<option value="0">----- Other Locations  -----</option>
<option value="/">olocation1</option>
<option value="/">olocation2</option>
<option value="/">olocation3</option>
</select>

I am creating a pulldown menu that pushes the user to a selected url. In the list i have several values that are set at 0 which i use for headers in the list. I have set them to 0 so they do nothing.

This works for the first one in the list which has a value of 0 but the others that do have a value of 0 still redirects the browser to a new website with the same domain and /0 at the end? What am i missing?

<select onchange="if (this.selectedIndex > 0) document.location.href=this.value;">
<option value="0" selected="selected">More...</option>
<option value="0">----- Locations  -----</option>
<option value="http://www.location1./">location1</option>
<option value="http://www.location2./">location2</option>
<option value="http://www.location3./">location3</option>
<option value="0">----- Other Locations  -----</option>
<option value="http://www.olocation1./">olocation1</option>
<option value="http://www.olocation2./">olocation2</option>
<option value="http://www.olocation3./">olocation3</option>
</select>

• javascript

Share Improve this question Follow asked Nov 28, 2012 at 1:57 MarkMark 40266 silver badges1818 bronze badges 1

• this.selectedIndex refers to the first, second, or third item in the list. Not the VALUE of what was clicked. this.value is what you are after. – mrtsherman Commented Nov 28, 2012 at 2:01

Add a ment  | 

2 Answers 2

Sorted by: Reset to default 4

change your code to:

<select onchange="if (this[this.selectedIndex].value !== '0') document.location.href=this.value;">
<option value="0" selected="selected">More...</option>
<option value="0">----- Locations  -----</option>
<option value="http://www.location1./">location1</option>
<option value="http://www.location2./">location2</option>
<option value="http://www.location3./">location3</option>
<option value="0">----- Other Locations  -----</option>
<option value="http://www.olocation1./">olocation1</option>
<option value="http://www.olocation2./">olocation2</option>
<option value="http://www.olocation3./">olocation3</option>
</select>​

demo: http://jsfiddle/pratik136/kWHXX/

Why?

Your code:

onchange="if (this.selectedIndex > 0) document.location.href=this.value;"

was checking for the index of the selected option in the list. Now because list indices start from 0, you were getting expected results when the first (or 0^th index) item was selected. But all other items passed the selectedIndex > 0 test and got redirected.

using

onchange="if (this[this.selectedIndex].value !== '0') document.location.href=this.value;"

basically checks for the value of the selected index, and if the value !== '0', it redirects to it.

You're redirecting them to the url 0, which it interprets as /0. You probably want to do a check to make sure that the value is not "0", by using something like this.value !== "0".

本文标签： javascriptonclick redirect to different urlStack Overflow