javascript - sonar code smell for reducer used in combineReducer - Stack Overflow

admin管理员组

文章数量:1296317

I am using bineReducer to bine reducers and reducer like this

const todo = (state = {}, action) => {
  switch (action.type) {
    //...

    case 'TOGGLE_TODO':
      if (state.id !== action.id) {
        return state
      }

      return Object.assign({}, state, {
        pleted: !statepleted
      })

    default:
      return state
  }
}

My problem is if i am defining reducer like that i am getting sonar code smell

Function parameters with default values should be last1

but bine reducer pass argument in this sequence only how to work on this?

I am using bineReducer to bine reducers and reducer like this

const todo = (state = {}, action) => {
  switch (action.type) {
    //...

    case 'TOGGLE_TODO':
      if (state.id !== action.id) {
        return state
      }

      return Object.assign({}, state, {
        pleted: !state.pleted
      })

    default:
      return state
  }
}

My problem is if i am defining reducer like that i am getting sonar code smell

Function parameters with default values should be last1

but bine reducer pass argument in this sequence only how to work on this?

• javascript
• reactjs
• redux
• sonarqube

Share Improve this question Follow edited Dec 5, 2018 at 9:14 Sergeon 6,78822 gold badges2727 silver badges4444 bronze badges asked Dec 5, 2018 at 9:10 Roli AgrawalRoli Agrawal 2,46633 gold badges2424 silver badges2929 bronze badges

Add a ment  | 

4 Answers 4

Sorted by: Reset to default 6

we did have the same issue within our project, and sonar allows you to define exclusions for rules and files in Administration -> Congifuration -> Analysis Scope.

you will find there a section called Ignore issues on Multiple Criteria and there you can enter the rule and a "file pattern" to exclude files from this rule.

like:

From the Sonarqube docs:

Function parameters with default values should be last:

...But all function parameters with default values should be declared after the function parameters without default values. Otherwise, it makes it impossible for callers to take advantage of defaults; they must re-specify the defaulted values or pass undefined in order to "get to" the non-default parameters.

This does, however, work with Redux as it calls your reducer for the first time with undefined as the first argument. If you want to continue using this pattern, you'll need to disable the rule or skip that line from analysis.

What if you define a default value for the second arg?

const todo = (state = {}, action = null/undefined) => {

Set action with {}:

for example, changing the below code

const todo = (state = {}, action) => { }

to this

const todo = (state = {}, action = {}) => { }

Will be the safest way.

本文标签： javascriptsonar code smell for reducer used in combineReducerStack Overflow