javascript - How do I promisify a GET request with query string? - Stack Overflow

admin管理员组

文章数量:1291383

I make a request successfully with querystring params:

// Works
var Promise = require("bluebird");
var request = Promise.promisifyAll(require("request"));

request.get({
    url: '/' + encodeURIComponent(friscoLocationTag) + '/startups', 
    qs: {
        access_token: myToken,
        order: 'popularity'
    },
    method: 'GET'
}, function(error, response, body){
    // request success
    console.log(body);
});

However when I try to promisfy my request I am failing:

// Does Not Work
var Promise = require("bluebird");
var request = Promise.promisifyAll(require("request"));

request.get({
    url: '/' + encodeURIComponent(friscoLocationTag) + '/startups', 
    qs: {
        access_token: myToken,
        order: 'popularity'
    },
    method: 'GET'
}).then(function(error, response, body){
    console.log(body);
});

This gives the error:

}).then(function(error, response, body){
   ^
TypeError: undefined is not a function
    at Object.<anonymous> (/Users/connorleech/Projects/startup-locator/server/routes.js:36:4)

How do I properly promisify my get request using bluebird?

I make a request successfully with querystring params:

// Works
var Promise = require("bluebird");
var request = Promise.promisifyAll(require("request"));

request.get({
    url: 'https://api.angel.co/1/tags/' + encodeURIComponent(friscoLocationTag) + '/startups', 
    qs: {
        access_token: myToken,
        order: 'popularity'
    },
    method: 'GET'
}, function(error, response, body){
    // request success
    console.log(body);
});

However when I try to promisfy my request I am failing:

// Does Not Work
var Promise = require("bluebird");
var request = Promise.promisifyAll(require("request"));

request.get({
    url: 'https://api.angel.co/1/tags/' + encodeURIComponent(friscoLocationTag) + '/startups', 
    qs: {
        access_token: myToken,
        order: 'popularity'
    },
    method: 'GET'
}).then(function(error, response, body){
    console.log(body);
});

This gives the error:

}).then(function(error, response, body){
   ^
TypeError: undefined is not a function
    at Object.<anonymous> (/Users/connorleech/Projects/startup-locator/server/routes.js:36:4)

How do I properly promisify my get request using bluebird?

• javascript
• node.js
• request
• npm

Share Improve this question Follow asked Sep 10, 2015 at 17:02 Connor LeechConnor Leech 18.9k3232 gold badges110110 silver badges160160 bronze badges

Add a ment  | 

2 Answers 2

Sorted by: Reset to default 5

There are gotchas trying to promisfy the request module, the issue that you're running into is just one of them. I remend you to instead look at request-promise which is basically what you're trying to do, it is an implementation of the request module using bluebird promises

EDIT:

Install request-promise

npm install request-promise --save

Then:

var request = require('request-promise');

request({
    url: 'https://api.angel.co/1/tags/' + encodeURIComponent(friscoLocationTag) + '/startups', 
    qs: {
        access_token: myToken,
        order: 'popularity'
    },
    method: 'GET'
})
.then(function(body){
  console.log(body)
})

The promisified function is called getAsync. See docs

var Promise = require("bluebird");
var request = Promise.promisifyAll(require("request"));

request.getAsync({
    url: 'https://api.angel.co/1/tags/' + encodeURIComponent(friscoLocationTag) + '/startups', 
    qs: {
        access_token: myToken,
        order: 'popularity'
    },
    method: 'GET'
}).then(function(error, response, body){
    console.log(body);
});

本文标签： javascriptHow do I promisify a GET request with query stringStack Overflow