I pleted my home work and got perfect result. But i just want to check , is this the best way to create